Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: srandmember with count argument should return array of strings or array of unknown #1620

Merged
merged 3 commits into from
Jul 23, 2022

Conversation

joni7777
Copy link
Contributor

@joni7777 joni7777 commented Jul 14, 2022

Closes #1621

@joni7777 joni7777 changed the title Support srandmember with count argument, real return type fix: srandmember with count argument should return array of strings or array of unknown Jul 14, 2022
@luin
Copy link
Collaborator

luin commented Jul 16, 2022

Hey @joni7777 👋 ,

Good catch! However, RedisCommander.ts is generated from bin/index.js so changes should be made on that file.

@joni7777
Copy link
Contributor Author

@luin awesome, fixing

@joni7777
Copy link
Contributor Author

@luin Fixed it, i think it supports now the two variants (with and without count)

@luin
Copy link
Collaborator

luin commented Jul 22, 2022

Made some changes. LMK if they make sense. @joni7777

@joni7777
Copy link
Contributor Author

joni7777 commented Jul 23, 2022

Made some changes. LMK if they make sense. @joni7777

@luin Yea perfectly I think removing the unknown type is much better

@luin luin merged commit 5f813f3 into redis:main Jul 23, 2022
github-actions bot pushed a commit that referenced this pull request Jul 23, 2022
## [5.2.2](v5.2.1...v5.2.2) (2022-07-23)

### Bug Fixes

* srandmember with count argument should return array of strings ([#1620](#1620)) ([5f813f3](5f813f3))
@github-actions
Copy link

🎉 This PR is included in version 5.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

janus-dev87 added a commit to janus-dev87/ioredis-work that referenced this pull request Mar 1, 2024
## [5.2.2](redis/ioredis@v5.2.1...v5.2.2) (2022-07-23)

### Bug Fixes

* srandmember with count argument should return array of strings ([#1620](redis/ioredis#1620)) ([5f813f3](redis/ioredis@5f813f3))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants